Re: serf property caching

On 8/8/07, Hyrum K. Wright <hyrum_wright@mail.utexas.edu> wrote:
> The property we are interested in here is DAV:href, which gets returned
> correctly the first time. The second time it doesn't, because we aren't

The initial property retrieval is not tied to a peg rev, so we can't
necessarily reuse the DAV:href property as the DAV:href may change
between peg revs.

> explicitly asking for it, but rather the set of checked_in_props. (This
> set does *not* contain DAV:href, and I don't know why the initial call
> to retrieve_props() succeeds.) When I use all_props instead of
> checked_in_props, the DAV:href gets pulled from the cache correctly, and
> we don't hit the abort().

Instead of using all_props, I'd just add a new structure to ra_serf.h:

static const svn_ra_serf__dav_props_t href_props[] =
{
  { "DAV:", "href" },
  { NULL }
};

and use href_props rather than all_props.

Other than that minor nit, good catch! -- justin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Aug 10 18:32:44 2007