[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Fwd: [bug] "svn log" can output invalid XML]

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2007-08-08 18:13:37 CEST

Ben Collins-Sussman wrote:
> The bug here is that control characters are in your log message. Long
> long ago, we prevented control characters from entering the
> repository; they're illegal in repository filenames, and illegal in
> repository log messages as well. The repository should be rejecting
> the invalid data.

That's not actually true. The filesystem backend has no reason to reject
control characters -- it treats property values as opaque blobs of data --
and therefore does no such "protective" work. And as far as I can tell, the
only validation performed by the repository layer is that property names
with "svn:" prefixes don't fall in the "svn:wc:" or other "non-regular"
property namespaces.

This protection is provided, IIRC, by the client libraries.

C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Wed Aug 8 18:11:54 2007

This is an archived mail posted to the Subversion Dev mailing list.