[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Fwd: [bug] "svn log" can output invalid XML]

From: Ben Collins-Sussman <sussman_at_red-bean.com>
Date: 2007-08-08 18:09:58 CEST

The bug here is that control characters are in your log message. Long
long ago, we prevented control characters from entering the
repository; they're illegal in repository filenames, and illegal in
repository log messages as well. The repository should be rejecting
the invalid data.

So the real bug here isn't "how should we fix the XML?"; the bug "how
did you get control characters into your log message in the first
place?"

On 8/8/07, Antoine Pitrou <solipsis@pitrou.net> wrote:
>
> Can someone confirm this is a bug so I can enter it in the issue
> tracker ?
>
>
>
> -------- Message transféré --------
> De: Antoine Pitrou <solipsis@pitrou.net>
> À: dev@subversion.tigris.org
> Sujet: [bug] "svn log" can output invalid XML
> Date: Mon, 06 Aug 2007 14:55:48 +0200
>
> Hi,
>
> I've found that SVN can output some invalid XML with the log command. It
> happens when e.g. a commit message contains control characters. Those
> control characters are valid UTF-8 but are not allowed by the XML spec
> (XML only allows control characters 0x9, 0xA and 0xD : see
> http://www.w3.org/TR/REC-xml/#charsets ).
>
> This is a concrete example from an existing repository:
>
> svn log --xml -r 1722 svn://exaile.org/usr/local/svn/exaile/trunk | xmllint -
>
> The only solution I can think of is to completely strip those control
> characters when an XML output is desired.
>
> Regards
>
> Antoine.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Aug 8 18:08:11 2007

This is an archived mail posted to the Subversion Dev mailing list.