[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Comment/code inconsistency: svn_path_get_absolute

From: Daniel Rall <dlr_at_finemaltcoding.com>
Date: 2007-07-31 21:08:14 CEST

On Jul 30, 2007, at 7:26 AM, Malcolm Rowe wrote:

> On Mon, Jul 30, 2007 at 09:21:18AM -0400, C. Michael Pilato wrote:
>> Malcolm Rowe wrote:
>>> I'd go for the option of removing the canonicalisation from the
>>> implementation: if the contract always required canonicalised
>>> paths, we
>>> don't need to change it now just because we've been
>>> canonicalising by
>>> mistake.
>>
>> +1.
>>
>> (Just don't let Stefan know.) ;-)
>>
>
> Okay. Could someone cast an eye over this patch? I'm fairly sure we
> don't need to convert from UTF-8 paths to APR paths for URLs (and what
> would that even mean?). I also assume that we should re-canonicalise
> the result of apr_filepath_merge().
>
> This will produce slightly different results for non-canonicalised
> URLs,
> but that's okay: they're invalid for this function anyway.
...

Malcolm, this patch looks fine to me, and passes 'make check'.
+1

  - Dan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jul 31 21:00:17 2007

This is an archived mail posted to the Subversion Dev mailing list.