[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Comment/code inconsistency: svn_path_get_absolute

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2007-07-30 15:21:18 CEST

Malcolm Rowe wrote:
> On Mon, Jul 23, 2007 at 11:37:58PM -0700, Blair Zajac wrote:
>> The comment says the input path to svn_path_get_absolute() must be
>> canonicalized:
>>
>> But the first thing it does is to canonicalize it:
>>
>>
>>
>> Seems safer to change the comment, but at the top of svn_path.h it says all
>> paths must be canonicalized, except for paths passed to
>> svn_path_canonicalize() and svn_path_internal_style()
>>
>> Which should we change?
>>
>
> I'd go for the option of removing the canonicalisation from the
> implementation: if the contract always required canonicalised paths, we
> don't need to change it now just because we've been canonicalising by
> mistake.

+1.

(Just don't let Stefan know.) ;-)

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Mon Jul 30 15:19:54 2007

This is an archived mail posted to the Subversion Dev mailing list.