[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] add limit argument to svn_repos_history

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2007-07-25 18:53:51 CEST

Jens Peters wrote:
>> Seems useful in general, though! Even if you do go with Mike's
>> suggestion to make the callback say whether or not it should continue,
>> a "limit" argument is often helpful (I think SVK would use it), and so
>> if you go down Mike's path adding a function which takes a log
>> callback and a limit integer and returns a new log callback which does
>> the limit logic for you would be nice.

I see the following courses of action here as options:

  1. rev svn_repos_history() to add a 'limit' parameter and uses it
     exclusively to control continuation of the function.

  2. rev svn_repos_history() to add a 'limit' parameter and uses it
     in concert with callback cancellation to control continuation of
     the function.

  3. don't rev svn_repos_history(), and use callback cancellation
     exclusively to control continuation of the function.

I certainly don't perceive the need for any type of wrapping function here.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Wed Jul 25 18:52:39 2007

This is an archived mail posted to the Subversion Dev mailing list.