[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix for interactive merge-callback not supporting spaces in file paths

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2007-07-25 18:38:46 CEST

C. Michael Pilato wrote:
> Augie Fackler wrote:
>>> svn_path_shell_autoescape doesn't exist yet; I was suggesting that you
>>> (or somebody) write it. So I think it should DTRT on windows :-)
>> Ahh. I'm not sure if I'm sadistic enough to figure out windows escaping
>> rules... ;-)
>
> This feels like an APR task, anyway. (Not that we couldn't write it
> ourselves and donate it to that project.)
>
> In fact, *all* of this stuff feels like something the portability layer
> should be handling.
>
> I'm trying to remember the history here. We started with using
> svn_io_run_cmd() (and, ultimately, APR's process stuff), but that didn't
> work when the command itself had spaces in it. So we switched to using
> system(). But then we realized that the argument to the $EDITOR we're
> calling might have spaces in it, too, so we're playing the escaping game.
>
> Is it too much to ask for an APR function that accepts an array of input
> parameters and handles all these problematic cases for us (and for all
> others consumers of the APR library, for that matter)?!

Oooh... maybe I misremembered the reason we moved to system(). It was
wasn't because we wanted to support editor programs with spaces in their
paths, it was that the "editor" might have been defined as a program path
plus some arguments ('emacs -nw'). Right?

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Wed Jul 25 18:37:36 2007

This is an archived mail posted to the Subversion Dev mailing list.