[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix for interactive merge-callback not supporting spaces in file paths

From: David Glasser <glasser_at_mit.edu>
Date: 2007-07-25 18:16:20 CEST

On 7/25/07, Augie Fackler <durin42@gmail.com> wrote:
> The single quotes aren't actually needed for this patch, that's an
> artifact from way back when I isolated the bug. New version included.
> The file name we'll be editing in this callback is one of our
> tempfiles, so we know it'll have a safe name.

Oh, good point. Do you think that the documentation for
svn_cl__edit_file_externally should be explicit that the basename of
PATH must be shell-safe?

> I've started working on the "launch external tool" callback, and I'm
> wondering - does svn_path_shell_autoescape DTRT on Windows? With the
> external tool callback we're going to have to either duplicate some
> files or do some escaping so that things don't break when you work
> with files that contain weird characters (spaces, etc) in the name.

svn_path_shell_autoescape doesn't exist yet; I was suggesting that you
(or somebody) write it. So I think it should DTRT on windows :-)


David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 25 18:15:10 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.