[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix for interactive merge-callback not supporting spaces in file paths

From: David Glasser <glasser_at_mit.edu>
Date: 2007-07-25 17:49:33 CEST

On 7/25/07, Augie Fackler <durin42@gmail.com> wrote:
> + cmd = apr_psprintf(pool, "%s \'%s\'", editor, file_name);

Hmm. It does feel to me that it is *slightly* more likely that a user
file name would have a single quote in it ("David's version") than a
double quote. (And if you are using single quotes, you don't need the
backslashes there.)

Or really, assuming we're stuck with using "system" (which seems to be
the case) we might want to add an svn_path_shell_autoescape, which is
like svn_path_uri_autoescape but escapes with backslashes instead of
%nn codes... Not only would that let you edit files with weird names,
but you wouldn't need all of the directory-changing games in the first
place.

--dave

-- 
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 25 17:48:27 2007

This is an archived mail posted to the Subversion Dev mailing list.