[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[patch] Making -l a shortcut for --limit (again)

From: Daniel Rall <dlr_at_finemaltcoding.com>
Date: 2007-07-24 18:16:01 CEST

On Jul 23, 2007, at 9:15 AM, David Glasser wrote:

> Wee, bikeshed time!
>
> Every so often it is proposed that we make '-l' a shortcut for
> '--limit', specifically for 'svn log'. Here's the last time it came
> up:
>
> http://svn.haxx.se/dev/archive-2007-03/0476.shtml
>
> I don't think that discussion really got resolved. (Karl suggested
> polling users@; not sure if that ever happened.) My (biased)
> impression is that there are a fair number of developers who are in
> support of this, and another number who are opposed (mostly because of
> the "it's only one subcommand" factor).
>
> The main argument for: "I always use --limit (except when using -r)".
> Supporting evidence: svk (which has a very similar command-line to
> svn) has had -l for years, and svk users (such as myself) seem to find
> this a big convenience. It's also worth noting that --limit is the
> only command-line argument that we've come up with in the first 7
> years of Subversion that begins with L.
>
> I honestly don't understand the counterargument well. "svn log
> --limit" is a feature we've had for years, and a non-trivial set of
> people say they ~always use it. On the other hand, we're devoting
> '-g' in 1.5 to a feature that nobody has used yet (and '-g' isn't even
> as mnemonically associated to its expansion as '-l' would be).
>
> I don't want to start a big bikeshed or do anything like call for a
> vote, but... I really would like to get more resolution on this than
> "a bunch of people want it! a bunch of people don't want it!".

[[[
Support '-l' as a short option for 'log --limit'.

* subversion/svn/cl.h
   (svn_cl__longopt_t): Remove svn_cl__limit_opt.

* subversion/svn/main.c
   (svn_cl__options, svn_cl__cmd_table, main): Replace use of
    svn_cl__limit_opt with 'l'.

* subversion/tests/cmdline/log_tests.py
   (log_limit): Change one invocation of 'log --limit' to 'log -l'.

Suggested by: glasser
]]]

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Tue Jul 24 18:08:50 2007

This is an archived mail posted to the Subversion Dev mailing list.