[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix for interactive merge-callback not supporting spaces in file paths

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2007-07-18 12:00:04 CEST

On 7/18/07, David Glasser <glasser@mit.edu> wrote:
> On 7/17/07, Daniel Rall <dlr@collab.net> wrote:
> > On Tue, 17 Jul 2007, David Glasser wrote:
> >
> > > On 7/17/07, Erik Huelsmann <ehuels@gmail.com> wrote:
> >
> > > > I've looked through it and I'm sad to have to say your approach won't
> > > > really work: Subversion is a library in a (possibly) multithreaded
> > > > program. Changing the working dir is not acceptable, because threads
> > > > my influence each other when doing that, getting in each others way.
> >
> > This change is to the command-line binary, not to the libraries. We
> > use apr_filepath_set() in three other places in this source file alone.
>
> Good point.

Ok. I missed both that we already use that function as well as that
this was cmdline client only. In that case, I think the current patch
is fine.

bye,

Erik.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Jul 18 11:59:22 2007

This is an archived mail posted to the Subversion Dev mailing list.