[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] fix for interactive merge-callback not supporting spaces in file paths

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-07-18 02:02:12 CEST

On Tue, 17 Jul 2007, David Glasser wrote:

> On 7/17/07, Erik Huelsmann <ehuels@gmail.com> wrote:

> > I've looked through it and I'm sad to have to say your approach won't
> > really work: Subversion is a library in a (possibly) multithreaded
> > program. Changing the working dir is not acceptable, because threads
> > my influence each other when doing that, getting in each others way.

This change is to the command-line binary, not to the libraries. We
use apr_filepath_set() in three other places in this source file alone.

...
> It's a tricky little problem. Why don't we tokenize the editor
> argument with apr_tokenize_to_argv and then use something like
> apr_proc_create which takes an argv error instead? That's what
> libsvn_ra_svn does (see its client.c(find_tunnel_agent)).

That sounds like a good approach, assuming it's actually necessary
give that Augie's patch looks fine already.

  • application/pgp-signature attachment: stored
Received on Wed Jul 18 02:01:26 2007

This is an archived mail posted to the Subversion Dev mailing list.