[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] add limit argument to svn_repos_history

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2007-07-13 16:11:16 CEST

Jens Peters wrote:
> Hello there,
>
> Attached is a patch that teaches svn_repos_history to use a limit
> argument, equivalent to svn_repos_get_logs3. The reason why I would like
> to have that functionality can be read here:
> http://viewvc.tigris.org/servlets/ReadMsg?list=dev&msgNo=2793. Any
> chance that this patch can made it into svn 1.5?
>
> Any reviews, remarks are welcome of course.

I don't have strong objections to adding a 'limit' argument to
svn_repos_history(), but I admit that I wonder if it is necessary. (And
retrospectively wonder if we even needed it for svn_repos_get_logs().)
Could the callback implementation not just keep track of how many times it
has been called and return SVN_ERR_CANCELLED (or perhaps a new
SVN_ERR_STOP_FEEDING_ME_INFORMATION_DARNIT) when its limit is reached?
Seems that this paradigm of universally allowing callback implementations to
gracefully terminate their driving function might yield greater flexibility
in the long-run.

Thoughts?

PS: A quick review of your patch looks promising, by the way, Jens! Glad to
see you over here in Subversion-land, too. :-)

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Fri Jul 13 16:10:41 2007

This is an archived mail posted to the Subversion Dev mailing list.