[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r25714 - branches/ctypes-python-bindings/csvn

From: Sage La Torra <sagelt_at_gmail.com>
Date: 2007-07-12 21:12:39 CEST

On 7/11/07, David James <james@cs.toronto.edu> wrote:
> On 7/10/07, sage@tigris.org <sage@tigris.org> wrote:
> > + svn_client_propset2(propname, svn_string_create(propval, self.pool),
> > + self._build_path(target), recurse, skip_checks,
> > + self.client, self.iterpool)
>
> Shouldn't the svn string be created from the iterpool, rather than the
> pool? Also, shouldn't we clear the iterpool at the end of the
> function?
>

Correct, thanks for the catch.

Changed pool usage in r25723.

Added proper pool clearing for propset and some other methods that needed it
in r25724.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 12 21:12:03 2007

This is an archived mail posted to the Subversion Dev mailing list.