[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r25692 - trunk/subversion/svn

From: David Glasser <glasser_at_mit.edu>
Date: 2007-07-09 21:07:41 CEST

On 7/9/07, C. Michael Pilato <cmpilato@collab.net> wrote:
> Garrett Rooney wrote:
> > IIRC there was a specific reason we used system(), but I can't recall
> > the details. Perhaps the archives would tell us...
>
> Yeah, I remember the same. Crawling the archives makes me think it had
> something to do with supporting editors with spaces in their command-lines
> (e.g., emacs -nw).

Hmm. This implies that we need to be careful about not passing files
with spaces or other shell metacharacters in their names as either the
"path" to svn_cl__edit_file_externally or as the "prefix" to
svn_cl__edit_string_internally.

A quick glance over the code implies that we're safe for now, though
(since the merge_file being edited with (e) has a boring temporary
filename).

--dave

-- 
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 9 21:07:23 2007

This is an archived mail posted to the Subversion Dev mailing list.