[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Redundant command-line options in 'svn propedit'?

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-07-09 20:56:41 CEST

"C. Michael Pilato" <cmpilato@collab.net> writes:
> This might be fixed already, but I just happened to notice that some of the
> command-line options which are supported by 'svn propedit' are listed twice
> in the output of 'svn help pedit':
>
> $ svn help pedit | grep editor
> propedit (pedit, pe): Edit a property with an external editor.
> --editor-cmd ARG : use ARG as external editor
> --editor-cmd ARG : use ARG as external editor
> $ svn help pedit | grep encoding
> --encoding ARG : treat value as being in charset encoding ARG
> --encoding ARG : treat value as being in charset encoding ARG
> $
>
> I haven't time to peek into this right now, but thought I'd mention it.

Fixed in r25693.

------------------------------------------------------------------------
r25693 | kfogel | 2007-07-09 11:55:07 -0700 (Mon, 09 Jul 2007) | 7 lines
Changed paths:
   M /trunk/subversion/svn/main.c

* subversion/svn/main.c
  (svn_cl__cmd_table): Don't list 'svn_cl__encoding_opt' and
    'svn_cl__editor_cmd_opt' explicitly, since they're already
    included in 'SVN_CL__LOG_MSG_OPTIONS'.

Found by: cmpilato

------------------------------------------------------------------------

Index: subversion/svn/main.c
===================================================================
--- subversion/svn/main.c (revision 25692)
+++ subversion/svn/main.c (revision 25693)
@@ -613,8 +613,7 @@
      "\n"
      "See 'svn help propset' for more on property setting.\n"),
     {'r', svn_cl__revprop_opt, SVN_CL__LOG_MSG_OPTIONS, SVN_CL__AUTH_OPTIONS,
- svn_cl__encoding_opt, svn_cl__editor_cmd_opt, svn_cl__force_opt,
- svn_cl__config_dir_opt} },
+ svn_cl__force_opt, svn_cl__config_dir_opt} },
 #endif
 
   { "propget", svn_cl__propget, {"pget", "pg"}, N_

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 9 20:56:23 2007

This is an archived mail posted to the Subversion Dev mailing list.