[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r25692 - trunk/subversion/svn

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2007-07-09 20:01:27 CEST

On 7/9/07, Ben Collins-Sussman <sussman@red-bean.com> wrote:
> On 7/9/07, Karl Fogel <kfogel@red-bean.com> wrote:
>
> > Hmmm, don't we have an APR-y way of invoking external commands? I
> > realize the system() call was in the code before, I just wonder if
> > this isn't an opportunity to upgrade to something more portable. (I
> > guess the main advantage of an APR-y way would be that the error code
> > would be meaningful.)
>
> Yeah, that thought crossed my mind as well... hmmm... I think we do
> something like when we run an external diff3 tool. Ah, yes, it looks
> like we have a whole svn_io_run_cmd() infrastructure, which ultimately
> calls apr_proc*() functions, manages process i/o, etc.
>
> Maybe 'svn propedit' and the conflict-callback should be using this
> code to launch $EDITOR? (Incidentally, I can't figure out where 'svn
> commit' is launching the editor!)

IIRC there was a specific reason we used system(), but I can't recall
the details. Perhaps the archives would tell us...

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 9 20:01:03 2007

This is an archived mail posted to the Subversion Dev mailing list.