[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r25517 - in trunk/subversion: include libsvn_client

From: David Glasser <glasser_at_mit.edu>
Date: 2007-07-06 13:56:56 CEST

On 6/26/07, Lieven Govaerts <svnlgo@mobsol.be> wrote:
> Malcolm Rowe wrote:
> > It strikes me that a public macro that says "don't use this" isn't
> > particularly useful to other users of the API. Is there any reason not
> > to just inline the definition into the single place it's used?
> >
> Malcolm, thanks for the review.
>
> There is a second place in which this macro should be used, that's in
> svn/main.c 1609. But I forgot to change it, so thx for the reminder! ;)
>
> The reason why I added a second macro is to make it clear to users of
> the SVN_DEPTH_FROM_RECURSE macro that it doesn't give the correct
> results in all cases, more specifically when working with status.

In fact it ought to be used in more places, like
svnserve/serve.c(status)... (and I think somewhere in mod_dav_svn as
well)

--dave

-- 
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Jul 6 13:56:39 2007

This is an archived mail posted to the Subversion Dev mailing list.