[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Remove APR ICONV dependency on Windows (was SVN Win32 Developers -- need some help)

From: Mark Phippard <markphip_at_gmail.com>
Date: 2007-07-05 14:58:48 CEST

On 7/5/07, Ivan Zhakov <chemodax@gmail.com> wrote:
> On 7/3/07, D.J. Heap <djheap@gmail.com> wrote:
> > On 7/2/07, Ivan Zhakov <chemodax@gmail.com> wrote:
> > [snip]
> > > Here is revisited patch. Major vhanges from previous version:
> > > - Use MLang API for converting page name to page id.
> > > - All Windows stuff moved to separate file win32_xlate.c.
> > >
> > > [[[
> > > Remove APR ICONV dependency on Windows and use native Windows
> > > character conversion API (MultiByteToWideChar/WideCharToMultiByte).
> > >
> >
> >
> > I've built and posted binaries with this patch at:
> >
> > http://subversion.tigris.org/servlets/ProjectDocumentList?folderID=8682&expandFolder=8682&folderID=8682
> >
> > I still get 2 fs-test failures with VS6 -- haven't had time to dig
> > into them yet.
> >
> > Also, I think we should probably check the return of CoInit and not
> > call CoUninit if it fails (because CoInit/CoInitEx has already been
> > called with a different apartment or something).
> >
> Good point! I've added check for return value of CoInitialize() and
> also added logic to detect when COM already initialized for different
> apartment.
>
> I think that patch is acceptable for trunk, thus I've committed it in
> r25640. Review more than welcome :)
>
> On 7/3/07, Daniel Rall <dlr@collab.net> wrote:
> > Just a nitpick, but some of the formatting is pretty inconsistent with
> > the rest of the code base (use of Hungarian notation, lack of
> > whitespace between data type and value in type casts, etc.).
> Thanks, I've checked my patch again and fixed what I found.

Thanks Ivan.

Is it possible to build apr-util without iconv now? Or do we still
have to build apr-iconv and ship the DLL and just know that we are now
not actually using it?

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Jul 5 14:58:44 2007

This is an archived mail posted to the Subversion Dev mailing list.