[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r25561 - branches/ctypes-python-bindings/csvn

From: David James <james_at_cs.toronto.edu>
Date: 2007-07-02 01:32:14 CEST

> > Thanks for all the hints. Mostly just examples of me being forgetful
> > or falling back on C style. Committed as rev 25605.
Thanks Sage! Don't forget to CC the dev@ list. I have some more comments below.

> > Instead of asking users to pass in filenames, we could allow users to
> > pass in Python files to the 'diff' function, and converted these file
> > objects to APR file objects. Potentially we could just pass in a
> > temporary file to the diff function and write any output we find there
> > to the Python file (or StringIO object) that the user passes in. We
> > already use this trick in the wrapper for SubversionException.
> >
> > If you look at the interface for 'Repos.cat', you'll see that it's
> > pretty clean because users can just pass in any old Python file (even
> > 'sys.stdout' or a 'StringIO' object) and we'll write out the output to
> > that file. I like how clean and easy to use that interface is, and
> > it'd be great if our 'diff' interface was just as Pythonic.
> >
> > I'm not sure if the above idea is worth the effort it takes to
> > implement. It might be more trouble than it's worth, but since I was
> > thinking about it I thought I'd mention it.
> >
>
> I'll take a look. It shouldn't be too hard, I think, but we'll see.

I just took a look at this myself and it wasn't as hard as I expected.
I updated the diff interface to write to regular Python files in
r25610. Let me know if you notice any problems.

Cheers,

David

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 2 01:32:10 2007

This is an archived mail posted to the Subversion Dev mailing list.