[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r25607 - trunk/subversion/tests/cmdline

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: 2007-07-02 00:19:41 CEST

glasser@tigris.org wrote:
> Modified: trunk/subversion/tests/cmdline/commit_tests.py
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/tests/cmdline/commit_tests.py?pathrev=25607&r1=25606&r2=25607
> ==============================================================================
> --- trunk/subversion/tests/cmdline/commit_tests.py (original)
> +++ trunk/subversion/tests/cmdline/commit_tests.py Sun Jul 1 14:47:54 2007
> @@ -1936,16 +1936,8 @@
> # Now, commit and examine the output (we happen to know that the
> # filesystem will report an absolute path because that's the way the
> # filesystem is created by this test suite.
> - expected_output = [ "Sending "+ iota_path + "\n",
> - "Transmitting file data .\n",
> - "Committed revision 2.\n",
> - "\n",
> - "Warning: 'post-commit' hook failed (exited with a "
> - "non-zero exitcode of 1). The following error output "
> - "was produced by the hook:\n",
> - "Post-commit hook failed\n",
> - ]
> -
> + expected_output = "Post-commit hook failed"
> +
> svntest.actions.run_and_verify_svn(None, expected_output, [],
> 'ci', '-m', 'log msg', iota_path)
>
David,

while I have no problem with the idea of changing 1.4 tests to pass with
a trunk server, in this case we loose the part that tests the fix for
issue 2648.
So I'm negative on this change.

Like I said on IRC yesterday, we should do two things:
- start adding a "@since version" flag on tests, where the version is
the oldest (active) version for which the test passes.
- stop changing existing tests to test for changed behavior, which is
exactly what happened here.

Is it really necessary that that test passes in 1.4 before we have
implemented above?

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jul 2 00:15:52 2007

This is an archived mail posted to the Subversion Dev mailing list.