Re: [PATCH] Build both serf and dav

On 6/18/07, David Glasser <glasser@mit.edu> wrote:
> On 6/13/07, David Glasser <glasser@mit.edu> wrote:
> > > * It only checks the [global] section, not the host-specific
> > > sections. This is probably not acceptable (if we want to not have
> > > host-specific preferences, then the pref should be in the main
> > > config file, not the servers file). All the code to choose
> > > sections is in libsvn_ra_dav, though.
> >
> > Somebody (I don't have time right now) really should do this before 1.5.
>
> Oh, ugh. The code that gets the host which is used to pick the group
> in ~/.subversion/servers is in libsvn_ra_dav and uses ne_uri_parse
> instead of apr_uri_parse.
>
> I don't know the details of these two functions; is there a chance
> that switching the libsvn_ra_dav calls from Neon to APR will parse
> bizarre URLs in a different way? Or should I just leave the calls in
> libsvn_ra_dav be and use apr_uri_parse in the RA loader and hope
> nothing is inconsistent?

Done in r25535: you can now select neon or serf on a site-by-site basis.

I didn't change the ne_uri_parse calls in ra_neon to use apr_uri_parse
instead, so this does leave a possibility for inconsistency.

--dave

-- 
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org