[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Make ra_serf handle '403 Forbidden' response.

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: 2007-06-25 20:50:51 CEST

Justin Erenkrantz wrote:
> On 6/25/07, Lieven Govaerts <lgo@mobsol.be> wrote:
>> I have some problems to get the authz_tests working on my (Windows)
>> laptop with ra_serf. What happens is that svn will abort on all tests
>> the involve a '403 Forbidden' response from apache.
>> Am I the only one with this problem?
> Weird.
I get abort()'s while running lock_tests.py with and without the patch.
On Windows this pops up a modal dialog so it's very visible. When I
ignore the abort the tests pass! I wonder if people running the
testsuite with ra_serf on Linux get the same aborts but just ignore them
due to the tests still passing.
>> Attached patch will make ra_serf raise an error upon receiving a reponse
>> with code 403. It only does a minimum of cleanup before returning the
>> error. I think that's ok, but would appreciate a second opinion.
> +1 in concept.
> Do note that this will orphan the code in locks.c that checks for 403
> condition explicitly. I think it's okay and that section could then
> be removed - but there could be some fallout from capturing 403s
> everywhere. -- justin
I don't see any special handling of 403's in ra_neon, so I doubt that's
going to be a problem. But I'll make sure I got all lock tests passing
without abort's before I commit.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 25 20:46:35 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.