Re: svn commit: r25357 - in trunk/subversion/tests/cmdline: . svntest

On 6/14/07, Daniel Rall <dlr@collab.net> wrote:
> On Wed, 13 Jun 2007, David Glasser wrote:
> > Looks good to me (though maybe the predicates in prop_tests and
> > commit_tests want to move into svntest.main too?).
>
> I committed the patch in r25406.
>
> I thought of moving the other predicates, but wonder at the value if
> they're only used in that one source file (ATM). Do you think it's
> worth moving them into the test framework itself doing so to avoid the
> chance of redundant implementations springing up at a later date?

I think we first moved predicates into svntest.main after somebody
noticed me adding redundant implementations, so yeah, why not.

--dave

-- 
David Glasser | glasser_at_mit.edu | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org