[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r25357 - in trunk/subversion/tests/cmdline: . svntest

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-06-14 17:08:45 CEST

On Wed, 13 Jun 2007, David Glasser wrote:

> On 6/13/07, Daniel Rall <dlr@collab.net> wrote:
> >On Tue, 12 Jun 2007, David Glasser wrote:
> >
> >> On 6/12/07, Kamesh Jayachandran <kamesh@collab.net> wrote:
> >> >I originally thought on the same lines. But I could not pass a negating
> >> >expression as a lambda function.
> >>
> >> SkipUnless?
> >
> >Ah, good suggestion. How about this patch (attached), which adds and
> >uses the new predicate?
> Looks good to me (though maybe the predicates in prop_tests and
> commit_tests want to move into svntest.main too?).

I committed the patch in r25406.

I thought of moving the other predicates, but wonder at the value if
they're only used in that one source file (ATM). Do you think it's
worth moving them into the test framework itself doing so to avoid the
chance of redundant implementations springing up at a later date?

  • application/pgp-signature attachment: stored
Received on Thu Jun 14 17:10:37 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.