Re: [PATCH] libsvn-fs-util: Move more macros from BDB and FSFSback-end

On Tue, 2007-06-12 at 16:41 +0530, Kamesh Jayachandran wrote:
> Bhuvaneswaran Arumugam wrote:
> >
> > * subversion/include/private/svn_fs_util.h
> > (ALREADY_EXISTS, NOT_TXN, NOT_FOUND): Define new macros.
> >
> They should be
>
> ALREADY_EXISTS -> SVN_FS__ALREADY_EXISTS
> NOT_TXN -> SVN_FS__NOT_TXN
> NOT_FOUND -> SVN_FS__NOT_FOUND
>
>
>
>
> >
> > +/* Constructing nice error messages for roots. */
> > +
> > +/* Build an SVN_ERR_FS_NOT_FOUND error, with a detailed error text,
> > + for PATH in ROOT. */
> > +#define NOT_FOUND(r, p) ( \
> >
> Please name the macro as suggested above.
> I agree original macros had parameters as 'r' and 'p', Now these macros
> are in a private SDK, would be nice if you have descriptive param names
> and type specification.

Thanks for the review comment Kamesh.

Please find attached the revised patch as per your suggestion.

[[
Move and rename set of macros from BDB and FSFS backends to
libsvn-fs-util library. In addition, convert a function in FSFS backend
as macro and move it to libsvn-fs-util library.

* subversion/libsvn_fs_fs/tree.c
 (already_exists, not_txn): Remove the functions.
 (NOT_FOUND): Remove the macro.
 (fs_change_merge_info, fs_change_node_prop, fs_merge, fs_delete_node,
 fs_revision_link, fs_make_dir, fs_make_file): Use new macros.

* subversion/libsvn_fs_base/tree.c
 (ALREADY_EXISTS, NOT_TXN, NOT_FOUND): Remove the macros.

* subversion/include/private/svn_fs_util.h
 (SVN_FS__ALREADY_EXISTS, SVN_FS__NOT_TXN, SVN_FS__NOT_FOUND): Define
 new macros.
 (open_path, base_node_history, base_change_merge_info,
 base_change_node_prop, base_merge, base_make_dir, txn_body_delete,
 copy_helper): Use new macros.
     
Suggested by: bhuvan,
              dlr
              
]]

-- 
Regards,
Bhuvaneswaran