Re: [PATCH] libsvn-fs-util: Move more macros from BDB and FSFS back-end

Bhuvaneswaran Arumugam wrote:
>
> * subversion/include/private/svn_fs_util.h
> (ALREADY_EXISTS, NOT_TXN, NOT_FOUND): Define new macros.
>
They should be

ALREADY_EXISTS -> SVN_FS__ALREADY_EXISTS
NOT_TXN -> SVN_FS__NOT_TXN
NOT_FOUND -> SVN_FS__NOT_FOUND

>
> +/* Constructing nice error messages for roots. */
> +
> +/* Build an SVN_ERR_FS_NOT_FOUND error, with a detailed error text,
> + for PATH in ROOT. */
> +#define NOT_FOUND(r, p) ( \
>
Please name the macro as suggested above.
I agree original macros had parameters as 'r' and 'p', Now these macros
are in a private SDK, would be nice if you have descriptive param names
and type specification.

Thanks.

With regards
Kamesh Jayachandran

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Jun 12 14:00:06 2007