[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: SVN Win32 Developers -- need some help

From: Mark Phippard <markphip_at_gmail.com>
Date: 2007-06-04 22:45:22 CEST

On 6/4/07, Ivan Zhakov <chemodax@gmail.com> wrote:
> On 5/30/07, Mark Phippard <markphip@gmail.com> wrote:
> I totally agree with you that Subversion should able use Win32 api
> instead iconv for encoding conversion on Windows. Maintaining iconv on
> windows is hell now. But as I remember last discussion on this topic
> blocked by Branko (http://svn.haxx.se/dev/archive-2005-10/0683.shtml):
> >> Anyway... before proceeding any further with this patch, I'd like to see
> >> some definite answers about the recent report that Windows translation
> >> functions aren't reliable for all encodings. If that's true, repllacing
> >> apr_iconv would be taking a step backwards (and would therefore generate
> >> a -1 from me).

I think to be fair here, someone needs to raise a more specific
objection, such as pointing to an actual flaw not a hypothetical one.
I could turn this around and point to dozens of known crashes of
Windows because we use apr_iconv.

> I consider that right way is to teach apr-iconv use win32 api instead
> if doing this in Subversion itself. Also in apr-iconv we can hardcode
> names of encodings supported by Windows (as far I know Windows
> supports limited set of encodings)
> Also I had some technical comments on Stefan's patch. But I'm ready to
> solve it if we get some decision in concept.

There is so little code here, why involve apr_iconv? I think we
should just dump it.

Mark Phippard
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 4 22:45:32 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.