[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: SVN Win32 Developers -- need some help

From: Ivan Zhakov <chemodax_at_gmail.com>
Date: 2007-06-04 22:41:05 CEST

On 5/30/07, Mark Phippard <markphip@gmail.com> wrote:
> I think we really need to address the problems of APR ICONV in our
> next release. Please see this thread for some references:
> http://subversion.tigris.org/servlets/BrowseList?list=dev&by=thread&from=582337
> This library has always been a problem, when there are multiple
> clients installed and they used different compilers. But now with a
> mixture of APR ICONV 0.9.x and 1.1.x out there this problem is going
> to escalate. It crashes Subversion, which means it can also crash
> clients using Subversion.
> Stefan King did the work of creating an initial patch that replaces
> the dependency with Win32 API's. I think we just need some consensus
> that this is what we should do, and then get a developer to do it.
> I think this is important and we are going to have problems if we do
> not address this for 1.5.
Hi Mark,

I totally agree with you that Subversion should able use Win32 api
instead iconv for encoding conversion on Windows. Maintaining iconv on
windows is hell now. But as I remember last discussion on this topic
blocked by Branko (http://svn.haxx.se/dev/archive-2005-10/0683.shtml):
>> Anyway... before proceeding any further with this patch, I'd like to see
>> some definite answers about the recent report that Windows translation
>> functions aren't reliable for all encodings. If that's true, repllacing
>> apr_iconv would be taking a step backwards (and would therefore generate
>> a -1 from me).

I consider that right way is to teach apr-iconv use win32 api instead
if doing this in Subversion itself. Also in apr-iconv we can hardcode
names of encodings supported by Windows (as far I know Windows
supports limited set of encodings)

Also I had some technical comments on Stefan's patch. But I'm ready to
solve it if we get some decision in concept.

Ivan Zhakov
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Jun 4 22:41:27 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.