Re: [patch] Get Ruby bindings Wc tests passing with new editor APIs

Hi,

In <ae6cb1100706010715q5dcdde0u32225e3454775cb2@mail.gmail.com>
  "Re: [patch] Get Ruby bindings Wc tests passing with new editor APIs" on Fri, 1 Jun 2007 07:15:36 -0700,
  "Joe Swatosh" <joe.swatosh@gmail.com> wrote:

> > > The smallest changes I could think of to get the tests passing again.
> > > Specifically,
> > > this patch doesn't expose the new functionality.
> >
> > I think we should keep the tests failure until we implement
> > those functions correctly. If we apply the patch, we may forget
> > to implement them because the tests are passed.
> >
>
> That seems reasonable. How about:
>
> [[[
> add preserve_exts argument
>
> * subversion/bindings/swig/ruby/svn/wc.rb
> (update_editor, switch_editor) added new preserved_exts argument to
> forward.
>
> * subversion/bindings/swig/include/svn_containers.swg
> add "apr_array_header_t *preserved_exts" to the STRINGLIST types.
> ]]]

It seems good. Could you commit?

Thanks,

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org