[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r25206 - trunk/subversion/bindings/javahl/src/org/tigris/subversion/javahl

From: Blair Zajac <blair_at_orcaware.com>
Date: 2007-05-31 19:54:38 CEST

Daniel Rall wrote:
> On Thu, 31 May 2007, Mark Phippard wrote:
>
>> On 5/31/07, David Glasser <glasser@mit.edu> wrote:
>>> On 5/30/07, blair@tigris.org <blair@tigris.org> wrote:
>>>> Author: blair
>>>> Date: Wed May 30 11:32:51 2007
>>>> New Revision: 25206
>>>>
>>>> Log:
>>>> [ in subversion/bindings/javahl/ ]
>>>>
>>>> * src/org/tigris/subversion/javahl/NativeResources.java:
>>>> Style tweak, use 'if (null == X)' instead of 'if (X == null)'.
>>> This seems unnecessary, since 'if (X = null)' is not legal in Java.
>> +1
>>
>> This is guarding against a problem that cannot happen and is not
>> standard for any code style I have seen. I greatly prefer the other
>> style.
>
> So do I, mostly due to the fact that I'm so much more accustomed to
> seeing it, and that it conceptually makes more sense to me.

That's my C/C++ coding style creeping into Java, where it is a good idea
to that, since it is legal.

I'll revert the change.

Regards,
Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 31 19:54:58 2007

This is an archived mail posted to the Subversion Dev mailing list.