[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r25206 - trunk/subversion/bindings/javahl/src/org/tigris/subversion/javahl

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-05-31 19:12:27 CEST

On Thu, 31 May 2007, Mark Phippard wrote:

> On 5/31/07, David Glasser <glasser@mit.edu> wrote:
> >On 5/30/07, blair@tigris.org <blair@tigris.org> wrote:
> >> Author: blair
> >> Date: Wed May 30 11:32:51 2007
> >> New Revision: 25206
> >>
> >> Log:
> >> [ in subversion/bindings/javahl/ ]
> >>
> >> * src/org/tigris/subversion/javahl/NativeResources.java:
> >> Style tweak, use 'if (null == X)' instead of 'if (X == null)'.
> >
> >This seems unnecessary, since 'if (X = null)' is not legal in Java.
>
> +1
>
> This is guarding against a problem that cannot happen and is not
> standard for any code style I have seen. I greatly prefer the other
> style.

So do I, mostly due to the fact that I'm so much more accustomed to
seeing it, and that it conceptually makes more sense to me.

  • application/pgp-signature attachment: stored
Received on Thu May 31 19:13:35 2007

This is an archived mail posted to the Subversion Dev mailing list.