[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Is the runtime configuration seeping too deeply?

From: Peter Lundblad <plundblad_at_google.com>
Date: 2007-05-29 08:39:40 CEST

Karl Fogel writes:
> > I think I should change my code to do just that (and plan to do so). But
> > here's my real question -- should we also change svn_wc_get_status_editor3()
> > too, *removing* the 'config' parameter and adding the one 'default_ignores'
> > parameter it actually needs? svn_wc_get_default_ignores(), which takes a
> > 'config' hash, too, is the likely reason the status function takes a
> > 'config' -- it just gets passed thru to svn_wc_get_default_ignores().
> >
> > I can't put my finger on the exact reason, but the runtime configuration
> > area *feels* to me like something that only libsvn_client and individual
> > client programs should even know about -- that the WC, RA, and server-side
> > APIs should be ignorant of it, and take their instructions from their
> > callers directly. (And yes, this means that svn_wc_get_ignores() and
> > svn_wc_get_default_ignores() would need to be changed, too.)
> >
> > Thoughts?
>
> +1
>

+1 as well. If we find our selves passing lots of values around to functions,
(which also can get cumbersome), then we can make special-purpose structs.

Thanks,
//Peter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 29 08:41:10 2007

This is an archived mail posted to the Subversion Dev mailing list.