[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn merge -g crashes if there is no client side mergeinfo

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-05-25 09:48:03 CEST

On Thu, May 24, 2007 at 06:34:39PM +0530, Kamesh Jayachandran wrote:
> Malcolm Rowe wrote:
> > On Thu, May 24, 2007 at 03:48:18PM +0530, Kamesh Jayachandran wrote:
> >
> >> * subversion/libsvn_client/log.c
> >> (svn_client__suggest_merge_sources): Fix segfault if
> >> 'svn_client_get_mergeinfo' sets NULL mergeinfo hash.
> >>
> >>
> >
> > I wonder if it would make more sense for svn_client_get_mergeinfo()
> > to return an empty hash in this case? It would certainly be easier
> > on clients, unless there's some reason that you'd want to detect the
> > 'no mergeinfo' case most of the time?
> >
> No it was the behaviour you suggested pre r25068. In r25068 we changed the
> api to differentiate between no mergeinfo(i.e no prop by name svn:mergeinfo
> and empty svn:mergeinfo).
>

I suggested that? Oh, okay, sorry for the confusion :-).

Regards,
Malcolm

  • application/pgp-signature attachment: stored
Received on Fri May 25 09:48:15 2007

This is an archived mail posted to the Subversion Dev mailing list.