[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn merge -g crashes if there is no client side mergeinfo

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: 2007-05-24 15:04:39 CEST

Malcolm Rowe wrote:
> On Thu, May 24, 2007 at 03:48:18PM +0530, Kamesh Jayachandran wrote:
>
>> * subversion/libsvn_client/log.c
>> (svn_client__suggest_merge_sources):
>> Fix segfault if 'svn_client_get_mergeinfo' sets NULL mergeinfo hash.
>>
>>
>
> I wonder if it would make more sense for svn_client_get_mergeinfo()
> to return an empty hash in this case? It would certainly be easier
> on clients, unless there's some reason that you'd want to detect the
> 'no mergeinfo' case most of the time?
>
No it was the behaviour you suggested pre r25068. In r25068 we changed
the api to differentiate between no mergeinfo(i.e no prop by name
svn:mergeinfo and empty svn:mergeinfo).

With regards
Kamesh Jayachandran

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu May 24 15:24:39 2007

This is an archived mail posted to the Subversion Dev mailing list.