[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Likely JavaHL defect

From: Mark Phippard <markphip_at_gmail.com>
Date: 2007-05-23 19:30:52 CEST

JavaHL has this callback feature it uses for various purposes. A
recent (1.4?) change appears to be to call the callback when asking
for the passphrase on an http client certificate. When it does this,
it uses this method:

    /**
     * ask the user a question where she answers with a text.
     * @param realm for which server realm this information is
     * requested.
     * @param question question to be asked
     * @param showAnswer if the answer is shown or hidden
     * @return the entered text or null if canceled
     */
    public String askQuestion(String realm, String question,
                              boolean showAnswer);

Since we have had this callback implemented in Subclipse for years, I
am pretty sure this is the first time this method was ever actually
called by Subversion code. We always thought the boolean showAnswer
was an odd field. As in why does it even exist? Anyway, in this
scenario we are getting called by Subversion with a value of false in
this field. Consequently, our dialog did not give the user a field to
type the answer into. In this case, the passphrase.

Can someone look at the C++ code that is calling this and see why the
boolean was false? I just wonder if the method was not documented
correctly or something. For now, we just changed our dialog to ignore
that value.

I can file an issue, but will wait until I hear something.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 23 19:31:11 2007

This is an archived mail posted to the Subversion Dev mailing list.