[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Remove APR_ICONV dependency on Windows

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2007-05-16 23:17:35 CEST

Mark Phippard wrote:
>> * it uses new/delete instead of apr pools to reserve the memory
>
> I think you submitted a patch to the thread that does this.

Yes I did. But that was some time ago:
http://subversion.tigris.org/servlets/ReadMsg?listName=dev&msgNo=106703

But then, it got rejected with an argument I simply couldn't do anything
about:
http://subversion.tigris.org/servlets/ReadMsg?list=dev&msgNo=106869
I can't prove rumors wrong.

So this time I decided to not send the patch at all but keep it to
myself. Because I still can't prove that rumor wrong. So there was no
point in even trying.

>> Yes, I don't define APR_HAS_XLATE. If that isn't defined but WIN32 is,
>> then the windows APIs are used to convert from/to utf8.
>
> Using the "normal" Windows build would I have to edit the generated
> DSW files? I really need this in Subclipse and I do not need the
> --encoding option either.

Well, I'm using NAnt scripts to build all the libraries (that way,
patching them is much easier to do, and I can customize the build the
way I want and need to). I haven't really tried building with the *.dsp
files (*.dsw are the workspace files, I think you meant the *.dsp files
which are the project files for the builds).

First, you need to 'patch' apr-util:

apr-util\include\apu.hw (or apu.h if it already exists):
there's a define in there
#define APU_HAVE_APR_ICONV 1
#define APU_HAVE_ICONV 0
#define APR_HAS_XLATE (APU_HAVE_APR_ICONV || APU_HAVE_ICONV)
set APU_HAVE_APR_ICONV to 0 instead of 1.

Not sure if those defines are also set in the *.dsp files which the
Subversion build generator creates (as mentioned above, I don't use
them). If they're defined, you may have to change them too.

Just make sure that you test your build (e.g., by updating files with
non-ascii names) to make sure that the iconv files really are not
used/needed anymore.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed May 16 23:18:11 2007

This is an archived mail posted to the Subversion Dev mailing list.