Re: Remove APR_ICONV dependency on Windows

On 5/16/07, Stefan Küng <tortoisesvn@gmail.com> wrote:
> Mark Phippard wrote:
>
> >> Note: it does not work if conversions are needed from/to another locale
> >> than the local one. But since UI clients usually only convert to the
> >> current locale from/to utf8, that's not really an issue.
> >
> > I do not believe Subversion does any other kind of conversion either.
>
> Yes it does. You can for some APIs pass a param to force the output to
> be in another locale. I don't think the CL client uses those, but the
> APIs can do this.
> I haven't implemented this for two reasons:
> * I don't know how to convert a locale given as a string (e.g.,
> "iso-8859-1") into the value needed to pass to the Windows APIs.
> * TSVN doesn't use those anyway

Right, some of the commands take an --encoding option.

> > Stefan, what happened last time? Did you just get tired of the back
> > and forth and decide it was easy enough to handle in your build
> > system? It seemed like you addressed all the comments though, why did
> > this not get applied?
>
> Well, to be honest, I simply don't have the energy to deal with that
> anymore. So I just kept the patch for TSVN. And with this patch I was
> (and still am) absolutely sure that it will get rejected:
> * it doesn't work for conversions to/from a charset which is not set as
> the current one in the process/thread

It sounds like that would be needed.

> * it uses new/delete instead of apr pools to reserve the memory

I think you submitted a patch to the thread that does this.

> Yes, I don't define APR_HAS_XLATE. If that isn't defined but WIN32 is,
> then the windows APIs are used to convert from/to utf8.

Using the "normal" Windows build would I have to edit the generated
DSW files? I really need this in Subclipse and I do not need the
--encoding option either.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org