[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r25007 - in trunk/subversion: include libsvn_client svn tests/cmdline

From: Vlad Georgescu <vgeorgescu_at_gmail.com>
Date: 2007-05-15 23:12:41 CEST

Joe Swatosh wrote:
> [...]
>> @@ -1210,7 +1275,8 @@
>> pl_baton.props = *props;
>> pl_baton.pool = pool;
>>
>> - SVN_ERR(svn_client_proplist3(target, peg_revision, revision, recurse,
>> + SVN_ERR(svn_client_proplist3(target, peg_revision, revision,
>> + recurse ? svn_depth_infinity : svn_depth_empty,
>
> For my own edification, why does this not use SVN_DEPTH_FROM_RECURSE?
> (would result in svn_depth_files instead of svn_depth_empty when
> recurse is false)
> Is it worth a comment?

recurse=false needs to be mapped to svn_depth_empty, because a
non-recursive proplist should only fetch the target's properties. I
added a comment explaining that in r25033.

Thanks,
Vlad

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 15 23:12:53 2007

This is an archived mail posted to the Subversion Dev mailing list.