[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r25007 - in trunk/subversion: include libsvn_client svn tests/cmdline

From: Joe Swatosh <joe.swatosh_at_gmail.com>
Date: 2007-05-15 00:37:41 CEST

Hi,

On 5/13/07, vgeorgescu@tigris.org <vgeorgescu@tigris.org> wrote:
> Author: vgeorgescu
> Date: Sun May 13 10:10:40 2007
> New Revision: 25007
>
> Log:
> Add depth support to svn_client_proplist3.
>
> * subversion/include/svn_client.h
> * subversion/libsvn_client/prop_commands.c
> (svn_client_proplist3): Replace the recurse parameter with a depth. If the
> target is a URL, pass the depth parameter to remote_proplist(). If the
> target is a working copy, use the depth to determine which files or
> directories to fetch properties for.
> (svn_client_proplist2): Convert recurse to a depth when calling
> svn_client_proplist3().
> (remote_proplist): Take a depth parameter instead of a boolean recurse and
> use it to DTRT.
>
> * subversion/svn/proplist-cmd.c
> (svn_cl__proplist): Don't convert opt_state->depth to a boolean recurse, as
> svn_client_proplist3() now takes a real depth.
>
> * subversion/tests/cmdline/prop_tests.py:
> (recursive_base_wc_ops): Move the verify_output inner function to the top
> level.
> (url_props_ops): Remove this function's implementation of verify_output.
> (depthy_wc_proplist, depthy_url_proplist): New tests.
> (test_list): Add depthy_wc_proplist and depthy_url_proplist.
>
>

==============================================================================
> --- trunk/subversion/libsvn_client/prop_commands.c (original)
> +++ trunk/subversion/libsvn_client/prop_commands.c Sun May 13 10:10:40 2007

>
> SVN_ERR(svn_wc_adm_close(adm_access));
> @@ -1210,7 +1275,8 @@
> pl_baton.props = *props;
> pl_baton.pool = pool;
>
> - SVN_ERR(svn_client_proplist3(target, peg_revision, revision, recurse,
> + SVN_ERR(svn_client_proplist3(target, peg_revision, revision,
> + recurse ? svn_depth_infinity : svn_depth_empty,

For my own edification, why does this not use SVN_DEPTH_FROM_RECURSE?
(would result in svn_depth_files instead of svn_depth_empty when
recurse is false)
Is it worth a comment?

> proplist_receiver_cb, &pl_baton, ctx, pool));
>
> return SVN_NO_ERROR;
>

Thanks

--
Joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue May 15 00:37:56 2007

This is an archived mail posted to the Subversion Dev mailing list.