[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Ruby bindings test failures on Windows

From: Kouhei Sutou <kou_at_cozmixng.org>
Date: 2007-05-12 16:11:05 CEST

Hi Joe,

In <ae6cb1100705111906i7d70a99fkabceec4921155bdd@mail.gmail.com>
  "Re: Ruby bindings test failures on Windows" on Fri, 11 May 2007 19:06:42 -0700,
  "Joe Swatosh" <joe.swatosh@gmail.com> wrote:

> > > I changed assert_simple_provider to assert that no matter the provider, if no
> > > credentials are supplied then access is denied, when credentials are supplied
> > > access is allowed.
> > >
> > > Modified the tests to use the new assert_simple_provider (don't know if it
> > > makes even a little sense with the keychain provider, but it works for the
> > > others).
> > >
> > > This seems simpler to me. It may be too simple to be correct.
> >
> > OK. Your concept makes sence. I approve your concept.
> > Could you adapt your concept to the current test_client.rb style
> > and commit it?
> >
> > > Could you please explain what the original version of
> > > assert_simple_provider was
> > > doing?
> >
> > Perhaps I wanted to do what you did but I don't remember
> > that...
> >
>
> It sure looks like that what you intended....

> [[[
> Use the passed in method to add the provider then show that it doesn't work
> without a password, then does work with a password. Finish what kou started.
>
> * subversion/bindings/swig/ruby/test/test_client.rb
> (SvnClientTest#assert_simple_provider) finish implementing
> ]]]

Thanks! Could you commit the patch?

--
kou
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat May 12 16:11:34 2007

This is an archived mail posted to the Subversion Dev mailing list.