Re: Ruby bindings test failures on Windows

Hi

On 5/9/07, Kouhei Sutou <kou@cozmixng.org> wrote:
> Hi,
>
> > I changed assert_simple_provider to assert that no matter the provider, if no
> > credentials are supplied then access is denied, when credentials are supplied
> > access is allowed.
> >
> > Modified the tests to use the new assert_simple_provider (don't know if it
> > makes even a little sense with the keychain provider, but it works for the
> > others).
> >
> > This seems simpler to me. It may be too simple to be correct.
>
> OK. Your concept makes sence. I approve your concept.
> Could you adapt your concept to the current test_client.rb style
> and commit it?
>
> > Could you please explain what the original version of
> > assert_simple_provider was
> > doing?
>
> Perhaps I wanted to do what you did but I don't remember
> that...
>

It sure looks like that what you intended....

--
Joe
[[[
Use the passed in method to add the provider then show that it doesn't work
without a password, then does work with a password.  Finish what kou started.
* subversion/bindings/swig/ruby/test/test_client.rb
  (SvnClientTest#assert_simple_provider) finish implementing
]]]
Index: subversion/bindings/swig/ruby/test/test_client.rb
===================================================================
--- subversion/bindings/swig/ruby/test/test_client.rb	(revision 25000)
+++ subversion/bindings/swig/ruby/test/test_client.rb	(working copy)
@@ -1699,25 +1699,19 @@
     ctx = Svn::Client::Context.new
     setup_auth_baton(ctx.auth_baton)
-    ctx.add_simple_provider
+    ctx.send(method)
     assert_raises(Svn::Error::RaNotAuthorized) do
-      assert_equal(src, ctx.cat(svnserve_uri))
+      ctx.cat(svnserve_uri)
     end
     ctx = Svn::Client::Context.new
     setup_auth_baton(ctx.auth_baton)
-    ctx.add_simple_provider
+    ctx.send(method)
     ctx.add_simple_prompt_provider(0) do |cred, realm, username, may_save|
       cred.username = @author
       cred.password = @password
-      cred.may_save = true
     end
     assert_equal(normalize_line_break(src), ctx.cat(svnserve_uri))
-
-    ctx = Svn::Client::Context.new
-    setup_auth_baton(ctx.auth_baton)
-    ctx.send(method)
-    assert_equal(normalize_line_break(src), ctx.cat(svnserve_uri))
   end
   def test_simple_provider
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org