[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r24506 - in trunk/subversion: libsvn_wc tests/cmdline

From: Lieven Govaerts <lgo_at_mobsol.be>
Date: 2007-04-11 00:12:50 CEST

Malcolm Rowe wrote:
> On Mon, Apr 09, 2007 at 01:26:59PM -0700, lgo@tigris.org wrote:
>> --- trunk/subversion/libsvn_wc/questions.c (original)
>> +++ trunk/subversion/libsvn_wc/questions.c Mon Apr 9 13:26:59 2007
>> @@ -386,10 +386,11 @@
>> APR_FINFO_SIZE | APR_FINFO_MTIME | APR_FINFO_TYPE
>> | APR_FINFO_LINK, pool);
>> if ((err && APR_STATUS_IS_ENOENT(err->apr_err))
>> - || !(finfo.filetype & (APR_REG | APR_LNK)))
>> + || !(finfo.filetype == APR_REG ||
>> + finfo.filetype == APR_LNK))
>> {
>
> I think that Peter mentioned that this conditional also needs to be
> fixed so that it doesn't examine finfo if (err && !ENOENT), since
> the contents will be undefined.

You're right, it wasn't really clear what Peter meant, but now it is.
Should be fixed in r24524.

>> --- trunk/subversion/tests/cmdline/special_tests.py (original)
>> +++ trunk/subversion/tests/cmdline/special_tests.py Mon Apr 9 13:26:59 2007
>> + # directory seems to make svn thing the file is unchanged
>
> "think"

Fixed in r24521.

thanks,

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Apr 11 00:13:17 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.