Re: svn commit: r24506 - in trunk/subversion: libsvn_wc tests/cmdline

On Mon, Apr 09, 2007 at 01:26:59PM -0700, lgo@tigris.org wrote:
> --- trunk/subversion/libsvn_wc/questions.c (original)
> +++ trunk/subversion/libsvn_wc/questions.c Mon Apr 9 13:26:59 2007
> @@ -386,10 +386,11 @@
> APR_FINFO_SIZE | APR_FINFO_MTIME | APR_FINFO_TYPE
> | APR_FINFO_LINK, pool);
> if ((err && APR_STATUS_IS_ENOENT(err->apr_err))
> - || !(finfo.filetype & (APR_REG | APR_LNK)))
> + || !(finfo.filetype == APR_REG ||
> + finfo.filetype == APR_LNK))
> {

I think that Peter mentioned that this conditional also needs to be
fixed so that it doesn't examine finfo if (err && !ENOENT), since
the contents will be undefined.

> --- trunk/subversion/tests/cmdline/special_tests.py (original)
> +++ trunk/subversion/tests/cmdline/special_tests.py Mon Apr 9 13:26:59 2007
> + # directory seems to make svn thing the file is unchanged

"think"

Regards,
Malcolm