[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fix issue #2363: Ignore unreadable files with a warning.

From: John Szakmeister <john_at_szakmeister.net>
Date: 2007-04-06 20:43:30 CEST

Daniel Rall wrote:
>> Should I create a notification function and add it to the client
>> context? It would serve for any notification both in server and client.
>> It would be a function which would be passed a structure with a message,
>> and an svn_error_t.
> I believe that there was some discussion about this patch on IRC, but
> I didn't catch most of it. What's the status/summary?

I think it basically boiled down to the fact that
svn_config_get_config() is called directly by main(). There is no
client context at that point. So, if we want to dump a warning we need
to do it from main() of the client (and yes, every client would have to
do the same if they want the same behavior). Otherwise, we could clear
the error and return an empty configuration silently. The down side is
that you don't get a warning. The upside is that everyone benefits. We
could also add a callback, rev the api, and provide a warning that way.
  But it hardly seems worth the effort.

I think that's where we're at for the moment.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Apr 6 20:44:06 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.