[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Fix issue #2363: Ignore unreadable files with a warning.

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-04-06 00:39:56 CEST

On Mon, 02 Apr 2007, NicolŠs Lichtmaier wrote:

> >Ok. The log message is almost correct, but you didn't mention the
> >symbol you were changing the docs for in svn_config.h. This may seem
> >logical in the context of the message, but it isn't when you're
> >grepping through the logs for a symbol.
> Oh, I'll fix that.
> >> svn_error_clear(err);
> >> return SVN_NO_ERROR;
> >> }
> >>+ else if (! must_exist && err && APR_STATUS_IS_EACCES(err->apr_err))
> >>+ {
> >>+ svn_handle_warning(stderr, err);
> >>+ svn_error_clear(err);
> >>+ return SVN_NO_ERROR;
> >>+ }
> >
> >Unfortunately, things can't work this way. libsvn_subr is a library
> >and the library-using program may not see the output from
> >svn_handle_warning() (think GUI situations).
> >
> >What you could do is create a new notification, send that through the
> >notification callback in the ctx structure (which I presume is
> >available to one of the callers of svn_config__parse_file()) and
> >handle that notification in subversion/svn/notify.c...
> I did spend some time looking for something like that, and as I couldn't
> find anything I just used stderr. There seems to be no generic
> notification callback in the client context. There's only a WC related one.
> Should I create a notification function and add it to the client
> context? It would serve for any notification both in server and client.
> It would be a function which would be passed a structure with a message,
> and an svn_error_t.

I believe that there was some discussion about this patch on IRC, but
I didn't catch most of it. What's the status/summary?

  • application/pgp-signature attachment: stored
Received on Fri Apr 6 01:01:06 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.