[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r24383 - trunk/subversion/tests/cmdline/svntest

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-04-05 18:13:01 CEST

On Thu, 05 Apr 2007, Malcolm Rowe wrote:

> On Thu, Apr 05, 2007 at 11:06:24AM +0200, Michael Haggerty wrote:
> > hwright@tigris.org wrote:
> > > Author: hwright
> > > Date: Tue Apr 3 10:00:26 2007
> > > New Revision: 24383
> > >
> > > Log:
> > > In the test suite, use Python boolean values instead of integers masquerading
> > > as booleans.
> > >
> > > * subversion/test/cmdline/svntest/main.py:
> > > (windows, platform_with_os_wait, verbose_mode, cleanup_mode, enable_sasl):
> > > Use True and False, instead of 1 and 0.
> > >
> > >
> > > Modified:
> > > trunk/subversion/tests/cmdline/svntest/main.py
> > > [...]
> >
> > What version of Python is required for the test suite?
> >
>
> 2.0, so you're right, we need to fix this.
>
> I thought we already had our own custom True and False, but I can't find
> them now, so I guess not.

Yup, 2.0 -- I wondered the same thing when I saw this commit go by,
but didn't know in what version of Python True and False were
introduced.

I'd be in favor of the test suite defining True and False if they're
not already defined.

  • application/pgp-signature attachment: stored
Received on Thu Apr 5 18:13:29 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.