Re: [PATCH] remove redundant code

On Thu, Apr 05, 2007 at 09:28:08PM +0530, Kamesh Jayachandran wrote:
>
> >It would make more sense to fix libsvn_client to not do the redundant
> >resolution in the first place rather than work around the problem in the
> >'svn' binary.
> >
> >Regards,
> >Malcolm
> >
>
> I think you misunderstood. The code in libsvn_client/merge.c is correct
> it exists to handle the cases like svn merge -r5:6
> file:///path/to/repo/path1/path2@{2007-03-08}
>
> The fix is to avoid libsvn_client/merge.c doing redundant work because
> of unwanted input svn gives all the time.
>

Yes, and I'm suggesting that libsvn_client should be clever enough to
realise that a merge of file:///path_at_HEAD or path_at_BASE shouldn't require
an extra resolution step to get the peg revision.

In other words, I'd like to fix the problem for all clients, not just
one.

Regards,
Malcolm