[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug? svnadmin dump/svndumpfilter incompatible if using --deltas on dump

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2007-04-04 16:11:02 CEST

Erik Huelsmann wrote:
> On 4/4/07, Malcolm Rowe <malcolm-svn-dev@farside.org.uk> wrote:
>> On Sun, Apr 01, 2007 at 11:16:20AM +0100, Simon Young wrote:
>> > The bug: If you svndump using the -deltas switch, the resultant dump
>> cannot
>> > be processed by svndumpfilter
>> >
>>
>> This isn't so much a bug as a missing feature - svndumpfilter doesn't
>> know how to parse dumpfiles containing deltas.
>>
>> I've filed issue #2760 to cover this.
>
> I'm not sure this isn't intentional: what if part of the history of a
> file was filtered out? How do you reconstruct its contents?

I'm pretty sure it *was* intentional. But when I thought more about this,
I'm not sure it was necessary.

Delta chains are generated for line of history -- a line that's extended
only via edits and copies. svndumpfilter is a path-based filter only,
meaning it can only possibly break a line of history if that line changes
paths (crossing into the excluded paths region). But even when not in
--deltas mode, svndumpfilter can only correctly handle such an action when
the copied thing was a file that happened to be modified in the same
revision in which it was copied.

So, I think we could actually relax this a little bit and grow support for
the new format (to the extent it can be supported).

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Wed Apr 4 16:11:15 2007

This is an archived mail posted to the Subversion Dev mailing list.