[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] libsvn_fs_fs: The file system check function shouldbeconsistent

From: Bhuvaneswaran Arumugam <bhuvan_at_collab.net>
Date: 2007-04-03 13:37:04 CEST

On Mon, 2007-04-02 at 13:03 +0100, Malcolm Rowe wrote:
> On Mon, Apr 02, 2007 at 04:09:56PM +0530, Bhuvaneswaran Arumugam wrote:
> > In FSFS file system check function, svn_fs_fs__check_fs(), we check for
> > fs->path variable, while in the BDB counterpart, svn_fs_base__check_fs()
> > function we check for fs->fsap_data variable to check the file system.
> >
> I do wonder whether there's actually any benefit to these checks at all,
> given that the only way a caller [1] could trigger them would be to call
> svn_fs_new() directly, and even then, the cause'd be pretty obvious even
> if we didn't have the check.
> [1] Other than fs-loader.c, which I'd argue is trivially verifiable by
> eye.
> But <shrug>, +1 to commit, assuming you've tested it.

Malcolm, Thank you for reviewing this patch. Yeah, I've tested it and I
do not see any issues. Committed this in r24375.


Received on Tue Apr 3 13:37:20 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.